test(core): close hydrated session fixture

commit: 7aad900383e1974eaead3785ba2babc75dbba535
author: brice · 2mo ago · 2026-08-18 13:39 UTC
parent: 775d96b
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

2 files · +6 -13

M packages/core/context_budget_test.go +0 -12


@@ -359,18 +359,6 @@ func hasToolResultOmissionMarker(content []provider.Content) bool {
359	359		return false
360	360		}
361	361
362		-	func retainedToolResultTextBytesForCall(messages []provider.Message, callID string) int {
363		-	for _, message := range messages {
364		-	for _, content := range message.Content {
365		-	result, ok := content.(provider.ToolResultBlock)
366		-	if ok && result.CallID == callID {
367		-	return retainedToolResultTextBytes(result.Content)
368		-	}
369		-	}
370		-	}
371		-	return 0
372		-	}
373		-
374	362		func toolResultTextForCall(messages []provider.Message, callID string) string {
375	363		var text strings.Builder
376	364		for _, message := range messages {


@@ -359,18 +359,6 @@ func hasToolResultOmissionMarker(content []provider.Content) bool {
359		return false	359	return false
360		}	360	}
361			361
362	-	func retainedToolResultTextBytesForCall(messages []provider.Message, callID string) int {
363	-	for _, message := range messages {
364	-	for _, content := range message.Content {
365	-	result, ok := content.(provider.ToolResultBlock)
366	-	if ok && result.CallID == callID {
367	-	return retainedToolResultTextBytes(result.Content)
368	-	}
369	-	}
370	-	}
371	-	return 0
372	-	}
373	-
374		func toolResultTextForCall(messages []provider.Message, callID string) string {	362	func toolResultTextForCall(messages []provider.Message, callID string) string {
375		var text strings.Builder	363	var text strings.Builder
376		for _, message := range messages {	364	for _, message := range messages {

M packages/core/session_developer_test.go +6 -1


@@ -21,10 +21,15 @@ func TestOpenSessionHydratesDeveloperMessage(t *testing.T) {
21	21		if err := session.Close(); err != nil {
22	22		t.Fatal(err)
23	23		}
24		-	_, messages, err := OpenSession(path)
	24	+	opened, messages, err := OpenSession(path)
25	25		if err != nil {
26	26		t.Fatalf("OpenSession: %v", err)
27	27		}
	28	+	t.Cleanup(func() {
	29	+	if err := opened.Close(); err != nil {
	30	+	t.Errorf("close opened session: %v", err)
	31	+	}
	32	+	})
28	33		if len(messages) != 1 \|\| messages[0].Role != provider.RoleDeveloper {
29	34		t.Fatalf("messages = %#v, want one developer message", messages)
30	35		}

 	if err := session.Close(); err != nil {
 		t.Fatal(err)
 	}
-	_, messages, err := OpenSession(path)
+	opened, messages, err := OpenSession(path)
 	if err != nil {
 		t.Fatalf("OpenSession: %v", err)
 	}
+	t.Cleanup(func() {
+		if err := opened.Close(); err != nil {
+			t.Errorf("close opened session: %v", err)
+		}
+	})
 	if len(messages) != 1 || messages[0].Role != provider.RoleDeveloper {
 		t.Fatalf("messages = %#v, want one developer message", messages)
 	}