fix ci on windows: close reopened session in TestSessionRoundTrip

OpenSession returns a Session whose writer holds an append handle to
the jsonl file. The test never closed it, so t.TempDir's cleanup hit
'The process cannot access the file because it is being used by
another process' on windows (posix happily deletes open files).
Register a t.Cleanup that closes the reopened session.

commit: c0adbc43159a64b22a1d0bc73964146d0b06b97e
author: patriceckhart · 6mo ago · 2026-04-18 09:01 UTC
parent: 682c64f
signature: unsigned

1 file · +4 -1

M internal/core/core_test.go +4 -1


@@ -30,10 +30,13 @@ func TestSessionRoundTrip(t *testing.T) {
30	30		t.Fatal(err)
31	31		}
32	32
33		-	_, msgs, err := OpenSession(sess.Path)
	33	+	reopened, msgs, err := OpenSession(sess.Path)
34	34		if err != nil {
35	35		t.Fatal(err)
36	36		}
	37	+	// OpenSession returns a live append writer; close it before t.TempDir
	38	+	// runs cleanup, otherwise windows refuses to delete the open file.
	39	+	t.Cleanup(func() { _ = reopened.Close() })
37	40		if len(msgs) != 1 {
38	41		t.Fatalf("got %d messages", len(msgs))
39	42		}

 		t.Fatal(err)
 	}
-	_, msgs, err := OpenSession(sess.Path)
+	reopened, msgs, err := OpenSession(sess.Path)
 	if err != nil {
 		t.Fatal(err)
 	}
+	// OpenSession returns a live append writer; close it before t.TempDir
+	// runs cleanup, otherwise windows refuses to delete the open file.
+	t.Cleanup(func() { _ = reopened.Close() })
 	if len(msgs) != 1 {
 		t.Fatalf("got %d messages", len(msgs))
 	}