fix: simplify staticcheck conditions
- commit
- c636810807a9441ee289c0a3987cee7f9208fd78
- author
- brice · · 2026-08-06 12:43 UTC
- parent
- b75ebb7
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
2 files · +2 -2
M packages/agent/modes/interactive.go +1 -1
| @@ -1951,7 +1951,7 @@ func (i *Interactive) redraw() { | |||
| 1951 | 1951 | if len(belowInput) > 0 { | |
| 1952 | 1952 | // Running subagents sit immediately under the prompt by default. | |
| 1953 | 1953 | // Other below-input chrome keeps the existing breathing room. | |
| 1954 | - | if !lineInput && !(subagentBelow && len(subagentLines) > 0) { | |
| 1954 | + | if !lineInput && (!subagentBelow || len(subagentLines) == 0) { | |
| 1955 | 1955 | bottom = append(bottom, "") | |
| 1956 | 1956 | } | |
| 1957 | 1957 | bottom = append(bottom, belowInput...) | |
| @@ -1951,7 +1951,7 @@ func (i *Interactive) redraw() { | |||||
| 1951 | if len(belowInput) > 0 { | 1951 | if len(belowInput) > 0 { | ||
| 1952 | // Running subagents sit immediately under the prompt by default. | 1952 | // Running subagents sit immediately under the prompt by default. | ||
| 1953 | // Other below-input chrome keeps the existing breathing room. | 1953 | // Other below-input chrome keeps the existing breathing room. | ||
| 1954 | - | if !lineInput && !(subagentBelow && len(subagentLines) > 0) { | 1954 | + | if !lineInput && (!subagentBelow || len(subagentLines) == 0) { |
| 1955 | bottom = append(bottom, "") | 1955 | bottom = append(bottom, "") | ||
| 1956 | } | 1956 | } | ||
| 1957 | bottom = append(bottom, belowInput...) | 1957 | bottom = append(bottom, belowInput...) | ||
M packages/agent/modes/subagent_indicator.go +1 -1
| @@ -158,7 +158,7 @@ func compactSubagentActivity(snapshot subagents.AgentSnapshot) string { | |||
| 158 | 158 | // Heartbeats report "idle" even while a delegated turn is still running. | |
| 159 | 159 | // Keep the row meaningful in that interval instead of contradicting its | |
| 160 | 160 | // spinner and turn state. | |
| 161 | - | if activity != "" && !(activity == "idle" && snapshot.TurnState == subagents.TurnRunning) { | |
| 161 | + | if activity != "" && (activity != "idle" || snapshot.TurnState != subagents.TurnRunning) { | |
| 162 | 162 | return activity | |
| 163 | 163 | } | |
| 164 | 164 | switch snapshot.TurnState { | |
| @@ -158,7 +158,7 @@ func compactSubagentActivity(snapshot subagents.AgentSnapshot) string { | |||||
| 158 | // Heartbeats report "idle" even while a delegated turn is still running. | 158 | // Heartbeats report "idle" even while a delegated turn is still running. | ||
| 159 | // Keep the row meaningful in that interval instead of contradicting its | 159 | // Keep the row meaningful in that interval instead of contradicting its | ||
| 160 | // spinner and turn state. | 160 | // spinner and turn state. | ||
| 161 | - | if activity != "" && !(activity == "idle" && snapshot.TurnState == subagents.TurnRunning) { | 161 | + | if activity != "" && (activity != "idle" || snapshot.TurnState != subagents.TurnRunning) { |
| 162 | return activity | 162 | return activity | ||
| 163 | } | 163 | } | ||
| 164 | switch snapshot.TurnState { | 164 | switch snapshot.TurnState { | ||